impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4384: NPE when cols list has trailing comma
Date Thu, 27 Oct 2016 20:18:34 GMT
Matthew Jacobs has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4869

Change subject: IMPALA-4384: NPE when cols list has trailing comma
......................................................................

IMPALA-4384: NPE when cols list has trailing comma

The changes to introduce new PRIMARY KEY syntax allowed for
a table definition to have a list of cols, optionally
followed by a PRIMARY KEY clause. However, this rule
was broken and would allow for the list of columns followed
by a trailing comma.

[localhost:21000] > create table foo (id int, x int,);
Query: create table foo (id int, x int,)
ERROR: AnalysisException: null
CAUSED BY: NullPointerException: null

Change-Id: Ibc394dd7e687b501ae7887a51bed2f441d562760
---
M fe/src/main/cup/sql-parser.cup
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
2 files changed, 4 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/4869/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4869
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibc394dd7e687b501ae7887a51bed2f441d562760
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>

Mime
View raw message