impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Laszlo Gaal (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4153: Fix count(*) on all blank('') columns - test
Date Wed, 19 Oct 2016 13:00:37 GMT
Hello Michael Ho,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/4755

to review the following change.

Change subject: IMPALA-4153: Fix count(*) on all blank('') columns - test
......................................................................

IMPALA-4153: Fix count(*) on all blank('') columns - test

This change adds test coverage for the fixes committed for
IMPALA-2399 in commit 9ed3b685a109559fad8dd94f6c03af93e164305a.
It uses the table nulltable in the workload functional-query
to verify the materialization and counting of NULL and empty-
valued columns. The test can be run on any supported storage
and compression combination.

Change-Id: I23923f95f43d67977ee1520a1fc09ce297548b3f
---
M testdata/workloads/functional-query/queries/QueryTest/scanners.test
1 file changed, 26 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/4755/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I23923f95f43d67977ee1520a1fc09ce297548b3f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Laszlo Gaal <laszlo.gaal@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>

Mime
View raw message