impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4408: Omit null bytes for Kudu scans with no nullable slots.
Date Mon, 31 Oct 2016 21:48:41 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4408: Omit null bytes for Kudu scans with no nullable slots.
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4892/1/fe/src/main/java/org/apache/impala/analysis/TupleDescriptor.java
File fe/src/main/java/org/apache/impala/analysis/TupleDescriptor.java:

PS1, Line 315: d.isKuduScanSlot()
Isn't this implied if it's a Kudu table? We should remove if it is.


-- 
To view, visit http://gerrit.cloudera.org:8080/4892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I762ad9d5cc4198922ea4b5218c504fde355c49a5
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message