impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-3771: Expose kudu client timeout and set default
Date Sun, 30 Oct 2016 05:44:05 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-3771: Expose kudu client timeout and set default

Patch Set 2:

File be/src/exec/

PS2, Line 123: kudu::MonoDelta timeout = kudu::MonoDelta::FromMilliseconds(
             :       FLAGS_kudu_client_timeout_ms);
             :   b.default_rpc_timeout(timeout);
             :   b.default_admin_operation_timeout(timeout);
             :   KUDU_RETURN_IF_ERROR(b.Build(&client_), "Unable to create Kudu client");
This seems to be duplicated in the scan node. Can you factor it into a shared method?
File fe/src/main/java/org/apache/impala/service/

Line 43:   private static int kuduClientTimeoutMs_ = 3 * 60 * 1000;
This is also the default in Do we need to repeat it here?
File fe/src/main/java/org/apache/impala/service/

Line 43: import;
Nit: wouldn't com come before org, alphabetically?

PS2, Line 148:         Preconditions.checkState(parsedReplicas > 0);
Maybe add an if-check and throw a RuntimeException to make the error better understandable
to the user?
File fe/src/main/java/org/apache/impala/util/

PS2, Line 54: k
Nit: upper case 'Kudu'

Line 63:     return;
can this call already time out?
File tests/custom_cluster/

Line 63:   @CustomClusterTestSuite.with_args(
single line?

Line 70:   @CustomClusterTestSuite.with_args(
single line?

Line 76: 
nit: remove newlines at end of file

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Iad95e8e38aad4f76d21bac6879db6c02b3c3e045
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <>
Gerrit-Reviewer: Lars Volker <>
Gerrit-HasComments: Yes

View raw message