impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Add functional tests for compute stats with mt dop > 0.
Date Sat, 29 Oct 2016 20:57:19 GMT
Alex Behm has posted comments on this change.

Change subject: Add functional tests for compute stats with mt_dop > 0.
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4879/3/testdata/workloads/functional-query/queries/QueryTest/mt-dop-compute-stats.test
File testdata/workloads/functional-query/queries/QueryTest/mt-dop-compute-stats.test:

Line 3: compute stats alltypes
> why create this test case instead of running the existing 'compute stats' t
The existing compute stats test does not systematically run on all file formats, and several
of the .test files have insert/ctas that don't work with mt_dop. Refactoring the existing
test_compute_stats.py and .test file seemed much harder. I'm not even sure we want to run
all the obscure regression tests with mt_dop as well.

I'm happy to refactor the existing tests if you feel strongly, but that's going to take some
time.


http://gerrit.cloudera.org:8080/#/c/4879/3/tests/query_test/test_mt_dop.py
File tests/query_test/test_mt_dop.py:

Line 34:     # IMPALA-4332: The MT scheduler does not work for Kudu or HBase tables.
> just a reminder: this will change with the next set of coordinator changes.
Thanks. On my radar.


-- 
To view, visit http://gerrit.cloudera.org:8080/4879
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icd4e7e44f9f23f66e59ad1fb298e13da76ad817a
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message