impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3676: Use clang as a static analysis tool
Date Sat, 29 Oct 2016 00:31:08 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-3676: Use clang as a static analysis tool
......................................................................


Patch Set 9:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/4758/9/be/src/exec/hdfs-avro-scanner.cc
File be/src/exec/hdfs-avro-scanner.cc:

Line 933:     builder->CreateCondBr(ret_val, end_field_block, bail_out);
this still is buggy. but we have IMPALA-4061 to track that, so okay.


http://gerrit.cloudera.org:8080/#/c/4758/9/be/src/experiments/bit-stream-utils.8byte.inline.h
File be/src/experiments/bit-stream-utils.8byte.inline.h:

Line 100:     if (num_bits - bit_offset_ < size) {
the dcheck at line 92 contradicts the need for this if-stmt.  is the checker just getting
confused, or is there really a path where we can have num_bits > size?
if the checker is confused, can we just disable it here? adding this if-stmt makes it unclear
whether num_bits <= size is really an invariant or not.


http://gerrit.cloudera.org:8080/#/c/4758/9/be/src/util/aligned-new.h
File be/src/util/aligned-new.h:

Line 50: };
given that we only really use this for cache alignment, how did you test it?


http://gerrit.cloudera.org:8080/#/c/4758/9/be/src/util/thread-pool.h
File be/src/util/thread-pool.h:

Line 34: class ThreadPool : public CacheLineAligned {
was this aligned before? if not, why are we aligning it now?


-- 
To view, visit http://gerrit.cloudera.org:8080/4758
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4ed168488cb30ddeccd0087f3840541d858f9c06
Gerrit-PatchSet: 9
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message