impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4314: Standardize on MT-related data structures
Date Fri, 28 Oct 2016 20:32:01 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-4314: Standardize on MT-related data structures
......................................................................


Patch Set 3: Code-Review+1

(4 comments)

Looked at .cc / .thrift only.

http://gerrit.cloudera.org:8080/#/c/4853/3/be/src/runtime/coordinator.cc
File be/src/runtime/coordinator.cc:

PS3, Line 246: boost
remove boost::


PS3, Line 456: runtime
Will you file a JIRA to fix this?


http://gerrit.cloudera.org:8080/#/c/4853/3/be/src/scheduling/query-schedule.h
File be/src/scheduling/query-schedule.h:

Line 116:   void Validate() const;
Still missing mention of how this signals failure.


PS3, Line 201: /// TODO: why are these part of the schedule?
The alternative is that there is a pointer to the enclosing QueryExecState.


-- 
To view, visit http://gerrit.cloudera.org:8080/4853
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I465d0e15e2cf17cafe4c747d34c8f595d3645151
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message