impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3346: DeepCopy() Kudu rows into Impala tuples.
Date Fri, 28 Oct 2016 19:35:40 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-3346: DeepCopy() Kudu rows into Impala tuples.
......................................................................


Patch Set 3:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/4862/3//COMMIT_MSG
Commit Message:

Line 17: 
> TODO:
Done


http://gerrit.cloudera.org:8080/#/c/4862/3/be/src/exec/kudu-scanner.cc
File be/src/exec/kudu-scanner.cc:

Line 183:     Tuple* kudu_tuple = reinterpret_cast<Tuple*>(const_cast<void*>(krow.cell(0)));
> Is the const_cast necessary? We shouldn't be modifying the memory. Ok to le
Logically it's not necessary, but getting rid of it leads to having to also fix these:
* Tuple::DeepCopy() is not a const function
* ExecNode::EvalConjuncts() takes a TupleRow* and not a const TupleRow*
* ExprContext::Get*Val() take TupleRow* and not a const TupleRow*. These are called from EvalConjuncts().


Line 198:       *batch_done = true;
> Not your change but I think we should set *batch_done = false up the top of
Done


PS3, Line 215: 8 * (1 << 20)
> Let's make this a named constant just for clarity.
Removed this function in response to Matt's comment.


http://gerrit.cloudera.org:8080/#/c/4862/3/be/src/exec/kudu-scanner.h
File be/src/exec/kudu-scanner.h:

PS3, Line 79:   /// Asserts that all string slots in the given tuple have less than 8MB of
data.
            :   /// Kudu should never return values larger than 8MB.
            :   void ValidateVarLenKuduData(const Tuple* tuple) const;
> why do we need to bother checking this since it's their limitation not ours
removed


-- 
To view, visit http://gerrit.cloudera.org:8080/4862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic911e4eff9fe98bf28d8a1bab5c9d7e9ab66d9cb
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message