impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3342: Add thread counters to monitor plan fragment execution
Date Fri, 28 Oct 2016 18:26:45 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-3342: Add thread counters to monitor plan fragment execution
......................................................................


Patch Set 7: Code-Review+1

(2 comments)

LGTM once you make a couple of small changes.

http://gerrit.cloudera.org:8080/#/c/4633/7/be/src/runtime/runtime-state.cc
File be/src/runtime/runtime-state.cc:

PS7, Line 137: PlanFragmentThread
Let's call it "PlanFragmentThreads" to make it clear that there may be multiple threads.


http://gerrit.cloudera.org:8080/#/c/4633/7/be/src/runtime/runtime-state.h
File be/src/runtime/runtime-state.h:

Line 365:   /// Total CPU utilization for all threads in this plan fragment.
Let's group it with the other timers - above total_storage_wait_timer_


-- 
To view, visit http://gerrit.cloudera.org:8080/4633
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa88aa6f3371fa42d11ecc122f43c7d83623c300
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: anujphadke <aphadke@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Yonghyun Hwang
Gerrit-Reviewer: anujphadke <aphadke@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message