impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3346: DeepCopy() Kudu rows into Impala tuples.
Date Fri, 28 Oct 2016 16:40:52 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-3346: DeepCopy() Kudu rows into Impala tuples.
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4862/3//COMMIT_MSG
Commit Message:

Line 17: 
TODO:
1) Test cases with nullable/nonnullable slots.
2) Specify mem layout to client (depends on KUDU-1694)
3) Avoid mem copies (depends on KUDU-1695)


http://gerrit.cloudera.org:8080/#/c/4862/3/be/src/exec/kudu-scanner.h
File be/src/exec/kudu-scanner.h:

PS3, Line 79:   /// Asserts that all string slots in the given tuple have less than 8MB of
data.
            :   /// Kudu should never return values larger than 8MB.
            :   void ValidateVarLenKuduData(const Tuple* tuple) const;
why do we need to bother checking this since it's their limitation not ours? if they change
their buffer sizes in the future then we have to change this as well.


-- 
To view, visit http://gerrit.cloudera.org:8080/4862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic911e4eff9fe98bf28d8a1bab5c9d7e9ab66d9cb
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message