impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yonghyun Hwang (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3552: make incremental stats max serialized size configurable
Date Fri, 28 Oct 2016 16:32:34 GMT
Yonghyun Hwang has posted comments on this change.

Change subject: IMPALA-3552: make incremental stats max serialized size configurable
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4867/1/be/src/catalog/catalog.cc
File be/src/catalog/catalog.cc:

PS1, Line 78: catalog_class_, catalog_ctor_,
            :       load_in_background, num_metadata_loading_threads, sentry_config,
            :       FlagToTLogLevel(FLAGS_v), FlagToTLogLevel(FLAGS_non_impala_java_vlog),
            :       auth_to_local, principal
> No for both.
Then, let's include it here. :)


http://gerrit.cloudera.org:8080/#/c/4867/1/fe/src/main/java/org/apache/impala/service/JniCatalog.java
File fe/src/main/java/org/apache/impala/service/JniCatalog.java:

PS1, Line 83: boolean loadInBackground, int numMetadataLoadingThreads,
            :       String sentryServiceConfig, int impalaLogLevel, int otherLogLevel,
            :       boolean allowAuthToLocal, String kerberosPrincipal
> Its a good ramp-up task and I think we should do it here. This clean-up has
Agreed. However, I think current fix contains enough changes. I will create a new jira ticket
and take care of the clean up right after this commit. I want to minimize the scope of changes
for one commit.


-- 
To view, visit http://gerrit.cloudera.org:8080/4867
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I33684725a61eabc67237503e61178305d37d3cb5
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Yonghyun Hwang <yonghyun@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Yonghyun Hwang
Gerrit-Reviewer: Yonghyun Hwang <yonghyun@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message