impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4379: Fix and test Kudu table type checking
Date Thu, 27 Oct 2016 22:03:38 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-4379: Fix and test Kudu table type checking
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4857/2/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java:

Line 232:     if (!KuduTable.isKuduTable(msTbl)) {
Is the intention here to forbid changing the storage_handler? If so why not just do that?


http://gerrit.cloudera.org:8080/#/c/4857/2/testdata/workloads/functional-query/queries/QueryTest/kudu_alter.test
File testdata/workloads/functional-query/queries/QueryTest/kudu_alter.test:

Line 46: ImpalaRuntimeException: Table 'simple_new' does not represent a Kudu table. Expected
storage_handler 'com.cloudera.kudu.hive.KuduStorageHandler' but found 'foo'
This behavior seems a little strange because 'simple_new' is actually a Kudu table. The alteration
did not go through because we're changing it to a non-Kudu table. Why is that a problem?


-- 
To view, visit http://gerrit.cloudera.org:8080/4857
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I475273cbbf4110db8d0f78ddf9a56abfc6221e3e
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message