impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Huaisi Xu (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3552: make incremental stats max serialized size configurable
Date Thu, 27 Oct 2016 21:05:59 GMT
Huaisi Xu has posted comments on this change.

Change subject: IMPALA-3552: make incremental stats max serialized size configurable
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4867/1/be/src/catalog/catalog.cc
File be/src/catalog/catalog.cc:

PS1, Line 78: catalog_class_, catalog_ctor_,
            :       load_in_background, num_metadata_loading_threads, sentry_config,
            :       FlagToTLogLevel(FLAGS_v), FlagToTLogLevel(FLAGS_non_impala_java_vlog),
            :       auth_to_local, principal
> How about passing a TBackendConfig directly here. Basically make the constr
I remember you asked for a generic (config) for all jvms, since some of these are catalog
specific, I think the choice he has is to have a jvm config with separate sub field for different
services.


http://gerrit.cloudera.org:8080/#/c/4867/1/common/thrift/Types.thrift
File common/thrift/Types.thrift:

PS1, Line 233: TBackendConfig
This is not a backend config. it is more like a jvm config.. or config from backend? I think
technically there is no "backend" outside of impalad. e.g. you cannot say statestore and catalog
are backends. Just my two cents as this already becomes overly complicated.


-- 
To view, visit http://gerrit.cloudera.org:8080/4867
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I33684725a61eabc67237503e61178305d37d3cb5
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Yonghyun Hwang <yonghyun@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Yonghyun Hwang <yonghyun@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message