impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3346: DeepCopy() Kudu rows into Impala tuples.
Date Thu, 27 Oct 2016 20:40:26 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-3346: DeepCopy() Kudu rows into Impala tuples.
......................................................................


Patch Set 1:

nice!

As we discussed - do you wanna remove the varchar handling? Even though my change to explicitly
disallow it hasn't gone in, I think it should be OK to make the BE-side change.

wrt testing, I think we should have some tests that have some non-nullable cols (after the
PKs). While those tables can't be created in Impala yet, the python client should be able
to do so. There are tests in test_kudu.py that create kudu tables via the python API (in kudu_test_suite.py)
where nullable could be specified (would need to pass that info through temp_kudu_table()).
If you'd rather wait for the Impala changes to allow creating non-nullable columns, that's
fine too. It would probably also be worth testing with default values set on the kudu cols.

-- 
To view, visit http://gerrit.cloudera.org:8080/4862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic911e4eff9fe98bf28d8a1bab5c9d7e9ab66d9cb
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message