impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4314: Standardize on MT-related data structures
Date Thu, 27 Oct 2016 20:04:21 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-4314: Standardize on MT-related data structures
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

+2 on FE.

http://gerrit.cloudera.org:8080/#/c/4853/1/be/src/runtime/coordinator.cc
File be/src/runtime/coordinator.cc:

Line 457:   bool is_mt_execution = request.query_ctx.request.query_options.mt_dop > 0;
> didn't seem worth it. it would be a single bool instead of a single int wit
except that plans will contain filters that are silently never run, but ok works for me


http://gerrit.cloudera.org:8080/#/c/4853/2/be/src/scheduling/query-schedule.cc
File be/src/scheduling/query-schedule.cc:

Line 244:   if (fragment->partition.type == TPartitionType::UNPARTITIONED) {
> but this should be callable for a non-query stmt (so the coordinator doesn'
non-query stmts will exit this function in L242


-- 
To view, visit http://gerrit.cloudera.org:8080/4853
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I465d0e15e2cf17cafe4c747d34c8f595d3645151
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message