impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3812: Fix error message for unsupported types
Date Thu, 27 Oct 2016 18:55:36 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-3812: Fix error message for unsupported types
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/4859/1/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java
File fe/src/main/java/org/apache/impala/analysis/SelectStmt.java:

Line 214:       if (!expr.getType().isSupported() || expr.getType().isInvalid()) {
make isSupported() also cover invalid types


http://gerrit.cloudera.org:8080/#/c/4859/1/fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java:

Line 307:     // Unsupported type binary in a star expansion.
update comment


http://gerrit.cloudera.org:8080/#/c/4859/1/testdata/workloads/functional-query/queries/QueryTest/misc.test
File testdata/workloads/functional-query/queries/QueryTest/misc.test:

Line 143: ---- TYPES
can we remove these empty sections?


Line 146: ImpalaBeeswaxException: INNER EXCEPTION: <class 'beeswaxd.ttypes.BeeswaxException'>
MESSAGE: AnalysisException: Unsupported type 'DATE' in 'functional.unsupported_types.date_col'.
can shrink this to just "Unsupported type ..." right?


-- 
To view, visit http://gerrit.cloudera.org:8080/4859
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9019b4bfd219f94e554c795befd3ff5e39706ea9
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message