impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4381: Incorrect AVX version of BloomFilter::Or
Date Thu, 27 Oct 2016 17:46:25 GMT
Hello Tim Armstrong,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/4866

to look at the new patch set (#3).

Change subject: IMPALA-4381: Incorrect AVX version of BloomFilter::Or
......................................................................

IMPALA-4381: Incorrect AVX version of BloomFilter::Or

The iteration on the loop incrementing the loop variable by the wrong
amount. This version is hopefully clearer. I have tested it on an
AVX_enabled machine and I have inspected the assembly.

Change-Id: I18480c598fbf6b842398581acde6fc719c40ce27
---
M be/src/benchmarks/bloom-filter-benchmark.cc
M be/src/util/bloom-filter-test.cc
M be/src/util/bloom-filter.cc
3 files changed, 136 insertions(+), 123 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/4866/3
-- 
To view, visit http://gerrit.cloudera.org:8080/4866
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I18480c598fbf6b842398581acde6fc719c40ce27
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message