impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4379: Throw if Kudu table created with var/char
Date Thu, 27 Oct 2016 17:42:04 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-4379: Throw if Kudu table created with var/char
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4857/1//COMMIT_MSG
Commit Message:

PS1, Line 10: analysis
> Unless I am missing something, I don't think we need to do this type checki
Good point. I was thinking about the case where a kudu table is created with types impala
doesn't support, e.g. UNIXTIME_MICROS. But I'll handle that separately.


-- 
To view, visit http://gerrit.cloudera.org:8080/4857
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I475273cbbf4110db8d0f78ddf9a56abfc6221e3e
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message