impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4381: Incorrect AVX version of BloomFilter::Or
Date Thu, 27 Oct 2016 17:33:48 GMT
Jim Apple has posted comments on this change.

Change subject: IMPALA-4381: Incorrect AVX version of BloomFilter::Or
......................................................................


Patch Set 2:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/4866/1//COMMIT_MSG
Commit Message:

PS1, Line 10: This
> Typo
Done


http://gerrit.cloudera.org:8080/#/c/4866/1/be/src/util/bloom-filter-test.cc
File be/src/util/bloom-filter-test.cc:

Line 63: // Computes union of 'x' and 'y'. Computes twice with AVX enabled and disabled and
> Needs a comment - e.g. "Computes union of 'x' and 'y'. Computes twice with 
Done


http://gerrit.cloudera.org:8080/#/c/4866/1/be/src/util/bloom-filter.cc
File be/src/util/bloom-filter.cc:

PS1, Line 163: AVX_REGISTER_
> AVX_REGISTER_BYTES would be clearer I think.
Done


PS1, Line 164:  char* const in_end = in + n;
> This is confusing because it's not actually initializing the loop variable,
Done


PS1, Line 165: ; in != in_end; (in +
> unnecessary parens
I think it is clearer. The relative precedences of += and , are not something I keep in my
short-term memory.


Line 182:   }
> DCHECK that the directories are the same size.
Done


Line 203:             simd_out, _mm_or_si128(_mm_loadu_si128(simd_out), _mm_loadu_si128(simd_in)));
> Maybe put these in the for loop for consistency with the pattern above, lik
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4866
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18480c598fbf6b842398581acde6fc719c40ce27
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message