impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4381: Incorrect AVX version of BloomFilter::Or
Date Thu, 27 Oct 2016 17:18:48 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4381: Incorrect AVX version of BloomFilter::Or
......................................................................


Patch Set 1:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/4866/1//COMMIT_MSG
Commit Message:

PS1, Line 10: THis
Typo


http://gerrit.cloudera.org:8080/#/c/4866/1/be/src/util/bloom-filter-test.cc
File be/src/util/bloom-filter-test.cc:

Line 63: TBloomFilter BfUnion(const BloomFilter& x, const BloomFilter& y, bool * success)
{
Needs a comment - e.g. "Computes union of 'x' and 'y'. Computes twice with AVX enabled and
disabled and verifies both produce the same result."


http://gerrit.cloudera.org:8080/#/c/4866/1/be/src/util/bloom-filter.cc
File be/src/util/bloom-filter.cc:

PS1, Line 163: REGISTER_SIZE
AVX_REGISTER_BYTES would be clearer I think.


PS1, Line 164: const char *const in_end = in + n;
This is confusing because it's not actually initializing the loop variable, I think just extract
it onto the line before.


PS1, Line 165: (in += REGISTER_SIZE)
unnecessary parens


Line 182:   }
DCHECK that the directories are the same size.


Line 203:         ++simd_in;
Maybe put these in the for loop for consistency with the pattern above, like ++i, ++simd_in,
++simd_out


-- 
To view, visit http://gerrit.cloudera.org:8080/4866
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18480c598fbf6b842398581acde6fc719c40ce27
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message