impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3346: DeepCopy() Kudu rows into Impala tuples.
Date Thu, 27 Oct 2016 06:33:21 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-3346: DeepCopy() Kudu rows into Impala tuples.
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/4862/1/be/src/exec/kudu-scanner.cc
File be/src/exec/kudu-scanner.cc:

Line 191:     row->SetTuple(tuple_idx(), kudu_tuple);
If we just assume that tuple_idx() is 0, then we can just do something like:

  TupleRow* tmp_row = reinterpret_cast<TupleRow*>(&kudu_tuple);


http://gerrit.cloudera.org:8080/#/c/4862/1/be/src/exec/kudu-scanner.h
File be/src/exec/kudu-scanner.h:

Line 94:   int tuple_idx() const { return 0; }
Not your change but this generality seems wholly unnecessary, I think we can simplify other
code if we just assume it's 0.


http://gerrit.cloudera.org:8080/#/c/4862/1/be/src/runtime/tuple.cc
File be/src/runtime/tuple.cc:

Line 83:   DeepCopy(result, desc, pool);
E.g. this is dropping the Status on the floor.


http://gerrit.cloudera.org:8080/#/c/4862/1/be/src/runtime/tuple.h
File be/src/runtime/tuple.h:

Line 95:   Status DeepCopy(Tuple* dst, const TupleDescriptor& desc, MemPool* pool);
There are other callsites that need to be fixed to handle the status, aren't there?


-- 
To view, visit http://gerrit.cloudera.org:8080/4862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic911e4eff9fe98bf28d8a1bab5c9d7e9ab66d9cb
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message