impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA 2523: Make HdfsTableSink aware of clustered input
Date Thu, 27 Oct 2016 05:02:20 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA_2523: Make HdfsTableSink aware of clustered input
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4863/1/be/src/exec/hdfs-table-sink.cc
File be/src/exec/hdfs-table-sink.cc:

Line 594:     WriteClusteredRowBatch(state, batch);
this case is exercised by the tests for IMPALA-2521, however we don't have tests (yet) that
make sure we actually ever have one partition output file open. Any ideas how I could test
this easily with our current infrastructure?


-- 
To view, visit http://gerrit.cloudera.org:8080/4863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibeda0bdabbfe44c8ac95bf7c982a75649e1b82d0
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message