impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Harrison Sheinblatt (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Enabling end-to-end tests on a remote cluster
Date Thu, 27 Oct 2016 02:37:32 GMT
Harrison Sheinblatt has posted comments on this change.

Change subject: Enabling end-to-end tests on a remote cluster
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4769/1/bin/remote_data_load.py
File bin/remote_data_load.py:

PS1, Line 365: main
> I'm having a bit of trouble parsing this sentence. Can you clarify?
With the parser options directly in main() it would be difficult to invoke the main() logic
from another python script without shelling out to execute the script as a sub process. If
instead, you define the parse options in a separate method, and create a method that does
all the logic in main() but takes a parameter of the args, then another python program could
set an arg dictionary and invoke the main logic directly without need to shell out.


-- 
To view, visit http://gerrit.cloudera.org:8080/4769
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f443a1728a1d28168090c6f54e82dec2cb073e9
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Harrison Sheinblatt <hs7@hotmail.com>
Gerrit-Reviewer: Martin Grund <grundprinzip@gmail.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message