impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4374: Use new syntax for creating TPC-DS/H tables in Kudu stress test
Date Thu, 27 Oct 2016 02:04:08 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-4374: Use new syntax for creating TPC-DS/H tables in Kudu stress test
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

Looks good. Can we remove the kudu_master tbl property too?

http://gerrit.cloudera.org:8080/#/c/4860/1/testdata/datasets/tpcds/tpcds_kudu_template.sql
File testdata/datasets/tpcds/tpcds_kudu_template.sql:

PS1, Line 34: TBLPROPERTIES ('kudu.master_addresses' = '{kudu_master}:7051')
can we assume the impala cluster has the default kudu master set correctly already?


-- 
To view, visit http://gerrit.cloudera.org:8080/4860
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d501fb9c3cba00b1fb0f7b5941db49cbbda5a53
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message