impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4260: Alter table add column drops all the column stats
Date Wed, 26 Oct 2016 20:11:09 GMT
Thomas Tauber-Marshall has posted comments on this change.

Change subject: IMPALA-4260: Alter table add column drops all the column stats
......................................................................


Patch Set 2:

(1 comment)

The 'describe formatted' issue is unrelated.

I filed: https://issues.cloudera.org/browse/IMPALA-4372

http://gerrit.cloudera.org:8080/#/c/4845/1/testdata/workloads/functional-query/queries/QueryTest/compute-stats.test
File testdata/workloads/functional-query/queries/QueryTest/compute-stats.test:

Line 121: 'new_col2','INT',-1,-1,4,4
> Can you also add a test case for CHANGE and REPLACE columns as well?
Turns out this doesn't really work, due to a Hive issue.

I added a test for what does work, and I filed:
https://issues.apache.org/jira/browse/HIVE-15075
https://jira.cloudera.com/browse/CDH-46452


-- 
To view, visit http://gerrit.cloudera.org:8080/4845
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia373ec917efa7ab9f2a59b8a870b7ebc30175dda
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message