impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3788: Support for Kudu 'read-your-writes' consistency
Date Tue, 25 Oct 2016 23:51:23 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-3788: Support for Kudu 'read-your-writes' consistency
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4779/3/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:

Line 1163:   if (kudu_latest_observed_ts > 0) {
> why not carry the > 0 convention and just always set the session state?  lo
Done


http://gerrit.cloudera.org:8080/#/c/4779/3/be/src/service/query-exec-state.cc
File be/src/service/query-exec-state.cc:

Line 547:     }
> why is it better to do here rather than, say, ImpalaServer::UnregisterQuery
I think this could go in UnregisterQuery too. I put it here because I thought it made more
sense to do some post-query accounting in QES rather than UnregisterQuery(), which feels like
it should be focusing on unregistering (not that these we are particularly consistent to begin
with...).

It shouldn't matter if lock_ is held or not. I should be able to call this after BlockOnWait(),
or I can move it to Unregister if you prefer.


-- 
To view, visit http://gerrit.cloudera.org:8080/4779
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6bcb5fc218ad4ab935343a55b2188441d8c7dfbd
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message