impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3872: allow providing PyPi mirror for python packages
Date Tue, 25 Oct 2016 22:51:40 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-3872: allow providing PyPi mirror for python packages
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4770/2/infra/python/deps/pip_download.py
File infra/python/deps/pip_download.py:

PS2, Line 34: pypi_mirror
> Use all-caps for the name?
Done


PS2, Line 73:       pkg_url = "{0}/packages/{1}".format(pypi_mirror, pkg['path'])
> What about:
This doesn't work for me - if I have PYPI_MIRROR = "https://pypi.infra.cloudera.com/api/pypi/pypi-public"
then it strips off api/pypi/pypi-public automatically. I'm not sure why it's doing that.


-- 
To view, visit http://gerrit.cloudera.org:8080/4770
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc11f010332c0225121c86c9930e35c7ac01409c
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message