impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4023: don't attach buffered tuple streams to batches
Date Tue, 25 Oct 2016 22:38:47 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4023: don't attach buffered tuple streams to batches
......................................................................


Patch Set 9:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/4448/9/be/src/runtime/buffered-tuple-stream.cc
File be/src/runtime/buffered-tuple-stream.cc:

Line 653:     // the caller can pass the rows up the operator tree.
> let's make this comment actually be useful.  how about something like:
Done


http://gerrit.cloudera.org:8080/#/c/4448/9/be/src/runtime/row-batch.h
File be/src/runtime/row-batch.h:

PS9, Line 77: Different modes for flushing resources
> these are really different modes for flushing resources.  isn't it just a f
Done


PS9, Line 227: as soon as possible
> this is pretty vague.  how about saying what the rule is specifically:
That's clearer, thanks.


PS9, Line 242:  
> (that have not been attached to the batch)
Done


PS9, Line 243: .
> and deep copied.
Done. Had a few tries at wording this paragraph hopefully it's clearer now.


PS9, Line 244: This is used to control memory management for streaming rows
> this is kind of misleading and confusing now especially since "flush" contr
Just deleted it, I think it's unnecessary.


Line 246:   /// are not allowed to accumulate batches with the 'needs_deep_copy' flag.
> how about saying this is deprecated?
Added a TODO and reference to the JIRA.


-- 
To view, visit http://gerrit.cloudera.org:8080/4448
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6471422f86ce71e4c6ab277a276000051bc2e8ff
Gerrit-PatchSet: 9
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message