impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Vissapragada (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Removed dead join inversion code from Analyzer.
Date Mon, 24 Oct 2016 22:17:49 GMT
Bharath Vissapragada has posted comments on this change.

Change subject: Removed dead join inversion code from Analyzer.
......................................................................


Patch Set 1:

I ran the code analysis tool from my IDE and found huge amount of un-used code in the frontend.
I haven't verified each item but Analyzer class shows the following ones.

- isSubquery()
- resetSubquery()
- containsOuterjoinedTid(List<TupleId>)
- getEquivSlots(SlotId)
- removeRedundantExprs(List<Expr>)
- isConjunctAssigned(Expr)
- hasUnassignedConjuncts()
- getTargetDbName(FunctionName)
- getConjunct(ExprId)
- getEqJoinConjuncts()
- validateValueTransferGraph)

As per the analysis there are 4533 such warnings across the code :)

-- 
To view, visit http://gerrit.cloudera.org:8080/4827
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d8fff29c0f6b239796561c877acc709a178c108
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message