impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-2521: Add clustered hint to insert statements
Date Mon, 24 Oct 2016 18:35:00 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-2521: Add clustered hint to insert statements

Patch Set 9:


Thanks for the comments, please see PS9.
File fe/src/main/java/org/apache/impala/analysis/

Line 602:       }
> Thanks. The reason why it works without is that SortNode.init() during plan

Line 604:       if (matchFound && table_ instanceof KuduTable) {
> I vote for keep
File fe/src/main/java/org/apache/impala/analysis/

Line 603:       // Store exprs for Kudu key columns.
> add line breaks between if blocks, it's harder to navigate without those ('
File fe/src/main/java/org/apache/impala/analysis/

Line 237:    * outputs of aggregation.
> something missing there. (i know, not your fault.)
Yes, I couldn't figure out in git blame what that sentence originally meant. Since I don't
understand enough of the code to complete it, I removed it. Let me know if I should replace
it with something else.
File testdata/workloads/functional-planner/queries/PlannerTest/kudu.test:

Line 247: # IMPALA-2521: clustered insert into table adds sort node, correctly substituting
> you can't always see the correct substitution until you run the query (beca

Line 249: select id, name, maxzip as zip
> use fewer columns, add an analytic function in the inline view

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I412153bd8435d792bd61dea268d7a3b884048f14
Gerrit-PatchSet: 9
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Lars Volker <>
Gerrit-Reviewer: Marcel Kornacker <>
Gerrit-HasComments: Yes

View raw message