impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3211: provide toolchain build id for bootstrapping
Date Mon, 24 Oct 2016 17:59:57 GMT
Jim Apple has posted comments on this change.

Change subject: IMPALA-3211: provide toolchain build id for bootstrapping
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4771/2//COMMIT_MSG
Commit Message:

PS2, Line 10: cceeded
I think the reason Gerrit displays these in blue while the first two letters are black is
because "cceeded" is a 7-character git hash :-)


http://gerrit.cloudera.org:8080/#/c/4771/2/bin/impala-config.sh
File bin/impala-config.sh:

Line 56: : ${IMPALA_TOOLCHAIN_BUILD_ID=249-2267164200}
This could use a bit more explanation. How should a person discover this value? When should
it be changed?


-- 
To view, visit http://gerrit.cloudera.org:8080/4771
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibcc25ae82511713d0ff05ded37ef162925f2f0fb
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message