impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Add all build targets to CMake and speed up builds
Date Mon, 24 Oct 2016 17:47:48 GMT
Jim Apple has posted comments on this change.

Change subject: Add all build targets to CMake and speed up builds
......................................................................


Patch Set 1:

(5 comments)

Have you tested this in a clean environment, maybe with Docker or Jenkins?

http://gerrit.cloudera.org:8080/#/c/4790/1/bin/make_impala.sh
File bin/make_impala.sh:

Line 90:       echo "[-fe_only] : Builds fe only."
The reason for this flag is so that make_impala.sh still builds the backend if you pass it
no args?

If so, what would be the consequences of breaking compatibility and requiring -be if the user
wants to build the backend?


PS1, Line 92: ."
cand benchmarks


PS1, Line 96: like
What else?


PS1, Line 174: exit
This line can be omitted


http://gerrit.cloudera.org:8080/#/c/4790/1/buildall.sh
File buildall.sh:

PS1, Line 305: all
Should the meaning of "all" be put into make_impala.sh?


-- 
To view, visit http://gerrit.cloudera.org:8080/4790
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23617adf13bdeb034c24f6bba14b5ae480e8dd26
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message