impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Add distcc infrastructure.
Date Mon, 24 Oct 2016 17:29:43 GMT
Jim Apple has posted comments on this change.

Change subject: Add distcc infrastructure.
......................................................................


Patch Set 2:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/4820/1/bin/distcc/distcc.sh
File bin/distcc/distcc.sh:

Line 1: #!/bin/bash
> Needs a copyright header
Done


Line 46: fi
> Should be able to get rid of this, we don't pick the linker up from PATH no
Done


http://gerrit.cloudera.org:8080/#/c/4820/1/bin/distcc/distcc_env.sh
File bin/distcc/distcc_env.sh:

Line 1: # Licensed to the Apache Software Foundation (ASF) under one
> Needs a copyright header
Done


PS1, Line 44: and not fo
> Can you check if BUILD_FARM is defined and print a message? Otherwise peopl
Done


Line 131:         IMPALA_USE_DISTCC=true
> All this linker stuff is irrelevant now that we're using the toolchain link
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4bc78ad46dda13e4533183195af632f46377cae
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message