impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Minor fixes to remove more "cloudera"s from the code.
Date Sun, 23 Oct 2016 19:59:02 GMT
Jim Apple has posted comments on this change.

Change subject: Minor fixes to remove more "cloudera"s from the code.
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4774/1/tests/benchmark/report_benchmark_results.py
File tests/benchmark/report_benchmark_results.py:

Line 249:   url = 'https://api.github.com/repos/apache/incubator-impala/commits/' + commit_sha
> Yes, it seems that commits that land in both repos end up having different 
If by "both repos", you mean github.com/cloudera/Impala and github.com/apache/incubator-impala,
then I agree. However, 

(a) commits that land in the apache-hosted Impala repo at https://git-wip-us.apache.org/repos/asf?p=incubator-impala.git;a=summary
have the same hashes as those in the github mirror at github.com/apache/incubator-impala

and

(b) cloudera/Impaala is not receiving ANY new commits at the moment: https://issues.cloudera.org/browse/IMPALA-3691

As such, I doubt anyone is building from it anymore.


-- 
To view, visit http://gerrit.cloudera.org:8080/4774
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I27687a3b677def72f1867df54c8e50c93d5cab3a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message