impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3676: Use clang as a static analysis tool
Date Sun, 23 Oct 2016 19:45:53 GMT
Jim Apple has posted comments on this change.

Change subject: IMPALA-3676: Use clang as a static analysis tool
......................................................................


Patch Set 5:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/4758/2/be/CMakeLists.txt
File be/CMakeLists.txt:

Line 106: if ("${CMAKE_BUILD_TYPE}" STREQUAL "DEBUG")
> It sets up CMake to use clang as the C++ compiler (see bin/impala_impala.sh
Done


http://gerrit.cloudera.org:8080/#/c/4758/4/be/src/common/status.h
File be/src/common/status.h:

Line 212:     return *msg_; // NOLINT: clang-tidy thinks this might deref a nullptr
> I still think we should reword this to make it clear that it's a limitation
Done


http://gerrit.cloudera.org:8080/#/c/4758/1/be/src/runtime/coordinator.h
File be/src/runtime/coordinator.h:

> Either if the multiple instances of the struct are touched on a particularl
WFM


http://gerrit.cloudera.org:8080/#/c/4758/4/be/src/runtime/coordinator.h
File be/src/runtime/coordinator.h:

Line 432:   /// safe to concurrently read from filter_routing_table_.
> Can you revert these changes?
Done


http://gerrit.cloudera.org:8080/#/c/4758/1/be/src/util/runtime-profile.h
File be/src/util/runtime-profile.h:

Line 335
> I'm ok with this but we should revisit if there are a lot of spurious warni
SGTM


http://gerrit.cloudera.org:8080/#/c/4758/4/bin/run_clang_tidy.sh
File bin/run_clang_tidy.sh:

Line 46:   # This script has been tested when CORES is actually higher than the number of
cores on
> 2 space indents are the (imperfectly followed) standard in the shell script
Done


http://gerrit.cloudera.org:8080/#/c/4758/4/buildall.sh
File buildall.sh:

Line 256: 
> Remove extra blank line.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4758
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4ed168488cb30ddeccd0087f3840541d858f9c06
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message