impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Kornacker (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-1702: Enforce single-table consistency in query analysis.
Date Sat, 22 Oct 2016 18:54:44 GMT
Marcel Kornacker has posted comments on this change.

Change subject: IMPALA-1702: Enforce single-table consistency in query analysis.

Patch Set 15: Code-Review+2

File fe/src/main/java/org/apache/impala/analysis/

Line 294:     // same version of a table in a single query, we cache all referenced tables
add todo that we need to investigate whether to do this for other catalog objects as well
File fe/src/main/java/org/apache/impala/analysis/

Line 43:   // The target table of a table sink, at most one for a single query.
"may be null" is a better phrasing.

Line 44:   // Table id 0 is reserved for it. Set in analyze() query statement that produces
"Set in QueryStmt.analyze()."

Line 45:   // table sink, e.g. InsertStmt.analyze(), ModifyStmt.analyze(). Also, partition
remove last sentence, that goes without saying.

Line 179:         // Verify table level consistency in the same query by checking references
to the
"checking that"

Line 180:         // same table refer to the same table instance.
"same Table instance" is even more specific (because we're talking about objects from that

Line 202:       if (tbl != targetTable_) {
single line
File fe/src/main/java/org/apache/impala/analysis/

Line 201:     if (tableId != null) {
single line
File fe/src/test/java/org/apache/impala/planner/

Line 438:       if (descTbl.isSetTupleDescriptors()) {
precede w/ blank line

Line 447:     if (execRequest.isSetFragments() && !execRequest.fragments.isEmpty())
same here

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifad648b72684ae495ec387590ab1bc58ce5b39e2
Gerrit-PatchSet: 15
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Huaisi Xu <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Bharath Vissapragada <>
Gerrit-Reviewer: Dimitris Tsirogiannis <>
Gerrit-Reviewer: Huaisi Xu <>
Gerrit-Reviewer: Marcel Kornacker <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-HasComments: Yes

View raw message