impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Kornacker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-1702: Enforce single-table consistency in query analysis.
Date Sat, 22 Oct 2016 18:54:44 GMT
Marcel Kornacker has posted comments on this change.

Change subject: IMPALA-1702: Enforce single-table consistency in query analysis.
......................................................................


Patch Set 15: Code-Review+2

(10 comments)

http://gerrit.cloudera.org:8080/#/c/4349/15/fe/src/main/java/org/apache/impala/analysis/Analyzer.java
File fe/src/main/java/org/apache/impala/analysis/Analyzer.java:

Line 294:     // same version of a table in a single query, we cache all referenced tables
here.
add todo that we need to investigate whether to do this for other catalog objects as well


http://gerrit.cloudera.org:8080/#/c/4349/15/fe/src/main/java/org/apache/impala/analysis/DescriptorTable.java
File fe/src/main/java/org/apache/impala/analysis/DescriptorTable.java:

Line 43:   // The target table of a table sink, at most one for a single query.
"may be null" is a better phrasing.


Line 44:   // Table id 0 is reserved for it. Set in analyze() query statement that produces
a
"Set in QueryStmt.analyze()."


Line 45:   // table sink, e.g. InsertStmt.analyze(), ModifyStmt.analyze(). Also, partition
pruning
remove last sentence, that goes without saying.


Line 179:         // Verify table level consistency in the same query by checking references
to the
"checking that"


Line 180:         // same table refer to the same table instance.
"same Table instance" is even more specific (because we're talking about objects from that
class).


Line 202:       if (tbl != targetTable_) {
single line


http://gerrit.cloudera.org:8080/#/c/4349/15/fe/src/main/java/org/apache/impala/analysis/TupleDescriptor.java
File fe/src/main/java/org/apache/impala/analysis/TupleDescriptor.java:

Line 201:     if (tableId != null) {
single line


http://gerrit.cloudera.org:8080/#/c/4349/15/fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java
File fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java:

Line 438:       if (descTbl.isSetTupleDescriptors()) {
precede w/ blank line


Line 447:     if (execRequest.isSetFragments() && !execRequest.fragments.isEmpty())
{
same here


-- 
To view, visit http://gerrit.cloudera.org:8080/4349
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifad648b72684ae495ec387590ab1bc58ce5b39e2
Gerrit-PatchSet: 15
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message