impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4335: Don't send 0-row batches to clients
Date Sat, 22 Oct 2016 00:24:30 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-4335: Don't send 0-row batches to clients
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4787/2/be/src/exec/plan-root-sink.cc
File be/src/exec/plan-root-sink.cc:

Line 88:   // Don't enter the loop if batch->num_rows() == 0; no point triggering the consumer
with
> Yes, but we're not fixing this because we're saving some perf. We're making
I'm doing it for both reasons? It's a sensible optimization to make, now that I've noticed
it. Anyhow, comment now refers to both.


-- 
To view, visit http://gerrit.cloudera.org:8080/4787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7d339c1f9a55d9d75fb0e97d16b3176cc34f2171
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message