impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4335: Don't send 0-row batches to sink
Date Fri, 21 Oct 2016 23:54:55 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-4335: Don't send 0-row batches to sink
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

I suspect that whatever test we add may become stale pretty easily. The empty batch behavior
can change with various parameters that we're likely to tune.

http://gerrit.cloudera.org:8080/#/c/4787/2/be/src/exec/plan-root-sink.cc
File be/src/exec/plan-root-sink.cc:

Line 88:   // Don't enter the loop if batch->num_rows() == 0; no point triggering the consumer
with
This sounds rather benign. Mention that some clients may not handle empty batches correctly,
so we cannot return such batches.


-- 
To view, visit http://gerrit.cloudera.org:8080/4787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7d339c1f9a55d9d75fb0e97d16b3176cc34f2171
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message