impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala
Date Fri, 21 Oct 2016 22:31:55 GMT
Thomas Tauber-Marshall has posted comments on this change.

Change subject: IMPALA-3725 Support Kudu UPSERT in Impala

Patch Set 10:

File fe/src/main/java/org/apache/impala/analysis/

Line 121:   // If this is an INSERT, will contain one Expr for all non-partition columns of
> ... will contain one Expr for all non-partition columns of the target table

Line 124:   // If this is an UPSERT, will contain one Expr per column mentioned in the query
> will contain one Expr per mentioned column

Line 128: 
> As discussed, please clarify the "if (value == NULL)" part in the BE kudu-t

Line 131:   // Only used for UPSERT, set in prepareExpressions().
> mentionedUpsertColumns_?

Line 664:     ArrayList<Column> columns = table_.getColumnsInHiveOrder();
> ++col

Line 670:           resultExprs_.add(selectListExprs.get(i));
> single line

Line 754:     return TableSink.create(table_, isUpsert_ ? TableSink.Op.UPSERT : TableSink.Op.INSERT,
> easier to add a Preconditions.checkState(isUpsert_ ||
File testdata/workloads/functional-query/queries/QueryTest/kudu_crud.test:

Line 307: select false as valb, 'he' as name, id from tdata where id < 2
> let's also add an upsert test to see what happens when a PK column is NULL
It results in the query getting aborted, which as far as I can tell is not something that
our query test framework can currently handle.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I8df5cea36b642e267f85ff6b163f3dd96b8386e9
Gerrit-PatchSet: 10
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Dimitris Tsirogiannis <>
Gerrit-Reviewer: Matthew Jacobs <>
Gerrit-Reviewer: Thomas Tauber-Marshall <>
Gerrit-HasComments: Yes

View raw message