impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4241: remove spurious child queries event
Date Fri, 21 Oct 2016 21:21:52 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4241: remove spurious child queries event
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4768/1/be/src/service/query-exec-state.cc
File be/src/service/query-exec-state.cc:

PS1, Line 623: child_queries
> remind me why we don't put line 616->622 in this kind of conditional? ISTR 
We would need to add more state to QueryExecState that is redundant with ChildQueryExecutor's
state (since ChildQueryExecutor obviously knows whether any child queries were running). Normally
this wouldn't be too bad but currently the locking rules around QueryExecState's members are
so confusing I think we should avoid adding state unless it's necessary.


-- 
To view, visit http://gerrit.cloudera.org:8080/4768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3881d032622750444d750f161ad6843bdbd16c30
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message