impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4285: Fix Parquet scanner with MT DOP > 0 and no materialized slots.
Date Thu, 20 Oct 2016 22:57:51 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-4285: Fix Parquet scanner with MT_DOP > 0 and no materialized slots.
......................................................................


Patch Set 1:

(1 comment)

Also added a test.

http://gerrit.cloudera.org:8080/#/c/4767/1/be/src/exec/hdfs-scanner.h
File be/src/exec/hdfs-scanner.h:

Line 354:   int WriteEmptyTuples(RowBatch* row_batch, int num_tuples);
> is this version ever called?
Not used. I cleaned up this and the other WriteEmptyTuples() function since I thought it needed
improvement. Please take another look.

I think the function can be improved further (no need to evaluate conjuncts I think), but
it would be nice to get this fix in before that.


-- 
To view, visit http://gerrit.cloudera.org:8080/4767
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I79c0f6fd2aeb4bc6fa5f87219a485194fef2db1b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message