impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4329: Prevent crash in scheduler when no backends are registered
Date Thu, 20 Oct 2016 22:19:13 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-4329: Prevent crash in scheduler when no backends are registered
......................................................................


Patch Set 1:

(3 comments)

Thanks for the comments. Please see PS3.

http://gerrit.cloudera.org:8080/#/c/4776/1/be/src/scheduling/simple-scheduler.cc
File be/src/scheduling/simple-scheduler.cc:

PS1, Line 541:      
> indentation - did you clang-format?
I hadn't, done now (and added a pre-commit hook).


PS1, Line 541: "
> I think you should add an error code here (NO_REGISTERED_BACKENDS).
Done


Line 589:               replica_host.hostname, &backend_ip);
> can you elaborate on how an empty backend_config leads to that crash?  It's
Thanks for pointing this out, it is indeed not obvious.

After determining a remote read, the code would eventually try to take the top element of
assignment_ctx.assignment_heap_ in L975. Subsequently, when using the returned IP it would
segfault. I added this to the commit message, too.


-- 
To view, visit http://gerrit.cloudera.org:8080/4776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6d93158f34841ea66dc3682290266262c87ea7ff
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message