impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4329: Prevent crash in scheduler when no backends are registered
Date Thu, 20 Oct 2016 22:17:07 GMT
Lars Volker has uploaded a new patch set (#3).

Change subject: IMPALA-4329: Prevent crash in scheduler when no backends are registered
......................................................................

IMPALA-4329: Prevent crash in scheduler when no backends are registered

The scheduler crashed with a segmentation fault when there were no
backends registered: After not being able to find a local backend (none
are configured at all), the previous code would eventually try to return
the top of assignment_ctx.assignment_heap SelectRemoteBackendHost(),
but that heap would be empty. Subsequently, when using the IP address of
that heap node, a segmentation fault would occur.

This change adds a check and aborts scheduling with
an error. It also contains a test.

Change-Id: I6d93158f34841ea66dc3682290266262c87ea7ff
---
M be/src/scheduling/simple-scheduler-test-util.cc
M be/src/scheduling/simple-scheduler-test-util.h
M be/src/scheduling/simple-scheduler-test.cc
M be/src/scheduling/simple-scheduler.cc
M common/thrift/generate_error_codes.py
5 files changed, 35 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/4776/3
-- 
To view, visit http://gerrit.cloudera.org:8080/4776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6d93158f34841ea66dc3682290266262c87ea7ff
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>

Mime
View raw message