impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-3676: Use clang as a static analysis tool
Date Thu, 20 Oct 2016 17:19:15 GMT
Jim Apple has posted comments on this change.

Change subject: IMPALA-3676: Use clang as a static analysis tool

Patch Set 1:

File be/CMakeLists.txt:

Line 106: SET(CXX_FLAGS_TIDY "${CXX_FLAGS_TIDY} --gcc-toolchain=${GCC_ROOT}")
> Ah right, I didn't realise the ASAN build got the --gcc-toolchain flag in a
I think that might be just for building the toolchain. I tried changing it and compile_commands.json
didn't change.
File be/src/exprs/

Line 175
> I think it might manifest as a link-time error if you do anything with the 
File be/src/exprs/

PS2, Line 176: static
> It doesn't make a difference for correctness, and I don't see any reason we
File be/src/runtime/coordinator.h:

> See my other commetn about space savings
I'm interested in your thoughts on which struct reordering s are, in your opinion, worth it
File be/src/util/aligned-new.h:

Line 42:       throw std::bad_alloc();
> Missed responding to this one - no callers in the Impala codebase catch the
File be/src/util/runtime-profile.h:

Line 335
> I don't think there are enough RuntimeProfile objects to produce a noticabl
I have put these variables back in the logical (but suboptimaly packed) order and added a
NOLINT annotation. I think the default should be to pack your structs, but that it's fine
not to do so sometimes.


To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I4ed168488cb30ddeccd0087f3840541d858f9c06
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <>
Gerrit-Reviewer: Jim Apple <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-HasComments: Yes

View raw message