impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3211: provide toolchain build id for bootstrapping
Date Thu, 20 Oct 2016 16:46:52 GMT
Michael Brown has posted comments on this change.

Change subject: IMPALA-3211: provide toolchain build id for bootstrapping
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4771/1/bin/bootstrap_toolchain.py
File bin/bootstrap_toolchain.py:

PS1, Line 91:   file_name = "{0}-{1}-{2}-{3}.tar.gz".format(product, version, compiler, label)
            :   url_path = "/{0}/{1}/{2}-{3}/{1}-{2}-{3}-{4}.tar.gz".format(toolchain_build_id,
product,
            :       version, compiler, label)
Would you be agreeable to using kwargs in str.format()? That would allow you to have more
readable format strings.

  formatted_str = '{key1}/{key2}'.format(key1=value1, key2=value2)


-- 
To view, visit http://gerrit.cloudera.org:8080/4771
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibcc25ae82511713d0ff05ded37ef162925f2f0fb
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message