impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4120: Incorrect results with LEAD() analytic function
Date Wed, 19 Oct 2016 21:13:31 GMT
Michael Ho has posted comments on this change.

Change subject: IMPALA-4120: Incorrect results with LEAD() analytic function
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4740/1/be/src/exprs/agg-fn-evaluator.h
File be/src/exprs/agg-fn-evaluator.h:

PS1, Line 149:   /// Puts the finalized value from Tuple* src in Tuple* dst just as Finalize()
does.
             :   /// 'pool' is the MemPool used for allocating memory for the finalized value
(e.g.
             :   /// StringVal). However, unlike Finalize(), GetValue() does not clean up
state in src.
             :   /// GetValue() can be called repeatedly with the same src. Only used internally
for
             :   /// analytic fn builtins.
             :   void GetValue(FunctionContext* agg_fn_ctx, Tuple* src, Tuple* dst, MemPool*
pool);
> That makes sense. What you are suggesting is similar to what the PAGG node 
Actually, let's stick with copying out the string from the result_tuple for now. We probably
should update the interface of Serialize()/Finalize() down the road to directly copy the string
into a MemPool.


-- 
To view, visit http://gerrit.cloudera.org:8080/4740
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I85bb1745232d8dd383a6047c86019c6378ab571f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message