impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "anujphadke (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3920: TotalStorageWaitTime counter not populated for fragments with Kudu scan node
Date Tue, 18 Oct 2016 23:06:02 GMT
anujphadke has posted comments on this change.

Change subject: IMPALA-3920: TotalStorageWaitTime counter not populated for fragments with
Kudu scan node
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4639/3/be/src/exec/kudu-scan-node.h
File be/src/exec/kudu-scan-node.h:

PS3, Line 104:   static const std::string KUDU_ROUND_TRIPS
> *added back
Sorry these 2 lines came back after a rebase. There was a conflict.
Fixed it.

Ran a simple select * on a kudu table and verified it again that the TotalStorageWaitTime
reports a time in profile (after rebasing)

  Fragment F00:
      Instance 254e4c4f30d99581:aee4f2c500000001 (host=anuj-OptiPlex-9020:22000):(Total: 12.615ms,
non-child: 0.000ns, % non-child: 0.00%)
        Hdfs split stats (<volume id>:<# splits>/<split lengths>): 
         - AverageThreadTokens: 0.00 
         - BloomFilterBytes: 0
         - ExecTreePrepareTime: 201.421us
         - PeakMemoryUsage: 245.12 KB (251000)
         - PerHostPeakMemUsage: 273.12 KB (279680)
         - RowsProduced: 8 (8)
         - TotalCpuTime: 64.250ms
         - TotalNetworkReceiveTime: 0.000ns
         - TotalNetworkSendTime: 597.148us
         - TotalStorageWaitTime: 55.906ms


-- 
To view, visit http://gerrit.cloudera.org:8080/4639
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If0c793930799fdcaff53e705f94b52cadac2f53a
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: anujphadke <aphadke@cloudera.com>
Gerrit-Reviewer: Dan Burkert <danburkert@apache.org>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: anujphadke <aphadke@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message