impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Kornacker (Code Review)" <>
Subject [Impala-ASF-CR] PREVIEW IMPALA-2521: Add clustered hint to insert statements
Date Tue, 18 Oct 2016 06:18:40 GMT
Marcel Kornacker has posted comments on this change.

Change subject: PREVIEW IMPALA-2521: Add clustered hint to insert statements

Patch Set 1:

File fe/src/main/java/org/apache/impala/analysis/

Line 121:   private boolean hasClusteredHint_ = false;
might be better to use ternary logic here with a single Boolean (which can be null)

Line 631:         if (hasNoShuffleHint_) {
did you mean noclustered?

Line 632:           throw new AnalysisException("Conflicting INSERT hint: " + hint);
list both conflicting hints (otherwise it's hard to tell how to fix the problem, other than
dropping the hint).

also fix the other error messages.
File fe/src/main/java/org/apache/impala/analysis/

Line 68:    * sorted. Its source exprs are update to those in tupleSlotExprs.
second sentence incomprehensible.

Line 123:    * the exprs used by the SortNode refer to the materialized tuples instead of
don't refer to the sort node here, SortInfo shouldn't have to know about that
File fe/src/main/java/org/apache/impala/planner/

Line 275:   public PlanFragment addClusteringFragment(PlanFragment inputFragment,
you should move the logic (minus the createSortTupleInfo part that alex brought up) into createInsertFragment

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I412153bd8435d792bd61dea268d7a3b884048f14
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Lars Volker <>
Gerrit-Reviewer: Marcel Kornacker <>
Gerrit-HasComments: Yes

View raw message