impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] PREVIEW IMPALA-2521: Add clustered hint to insert statements
Date Tue, 18 Oct 2016 01:03:17 GMT
Lars Volker has posted comments on this change.

Change subject: PREVIEW IMPALA-2521: Add clustered hint to insert statements
......................................................................


Patch Set 1:

In a first round I'd like to ask for feedback on the overall approach and the open TODO's
in the code. The new method in DistributedPlanner.java is currenlty still very verbosly commented,
mostly because I tried to understand the control flow. I can remove most of the comments in
the next iteration, but I'd like to receive feedback if any of them are wrong.

-- 
To view, visit http://gerrit.cloudera.org:8080/4745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I412153bd8435d792bd61dea268d7a3b884048f14
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message