impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-2905: Move QueryResultSet implementations into separate module
Date Tue, 18 Oct 2016 00:50:16 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-2905: Move QueryResultSet implementations into separate module
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4736/2//COMMIT_MSG
Commit Message:

Line 7: IMPALA-2905: Move QueryResultSet implementations into separate module
Is this the right JIRA? IMPALA-2905 is fixed.


http://gerrit.cloudera.org:8080/#/c/4736/2/be/src/service/query-result-set.h
File be/src/service/query-result-set.h:

Line 27: #include <boost/scoped_ptr.hpp>
what for?


-- 
To view, visit http://gerrit.cloudera.org:8080/4736
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6ab883b62d3ec7012240edf8d56889349e7c0e32
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message